-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add service #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed AppointmentStatus and CancellationReason from CreateAppointmentDTos - Removed ConfirmationCode and CancellationReason from AppointmentDTos - Removed CancellationReason from UpdateAppoinmentDTos These changes simplify the DTOs by removing redundant or unnecessary information in appointment creation and updates.
… enum - Standardized holiday names for consistency - Ensured WeekDay enum is always non-null
…rom DTOs - Removed PenaltyAmount from CreateServiceDTos, ServicesDTos, and UpdateServiceDTos - Removed RegisteredCompanyId, CreatedAt, and UpdateAt from ServiceFilterDTos These changes simplify the DTOs by eliminating redundant or unnecessary properties.
- Implemented a method to validate appointment dates - Ensures appointments meet required date constraints
- RegisteredCompaniesService - AppointmentService - ServicesService - ReviewService - SchedulesService
- Configure TrimlyContext with SQL Server connection - Register repositories for appointments, registered companies, reviews, schedules, and services - Add generic repository registration
daylmao
reviewed
Mar 9, 2025
|
||
return ResultT<Guid>.Failure(Error.NotFound("404", "Appointment not found.")); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must validate if one hour has passed to confirm the appointment automatically
daylmao
reviewed
Mar 9, 2025
daylmao
reviewed
Mar 9, 2025
daylmao
requested changes
Mar 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧐
Done! |
daylmao
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR introduces several improvements and new features, including service implementations, DTO modifications, and validation enhancements.
Key Changes:
PenaltyAmount
and unnecessary properties.WeekDay
.isHoliday
parameter.entityCreateDto
for the create method in the generic service.GenerateConfirmationService
.IFormFile Image
and removed the status property.